Skip to content

Convert from setup.py to pyproject.toml#51

Merged
aelanman merged 1 commit into
aelanman:mainfrom
lpsinger:pyproject-toml
May 11, 2026
Merged

Convert from setup.py to pyproject.toml#51
aelanman merged 1 commit into
aelanman:mainfrom
lpsinger:pyproject-toml

Conversation

@lpsinger

@lpsinger lpsinger commented May 8, 2026

Copy link
Copy Markdown
Contributor

Fixes #25.

@bhazelton bhazelton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, thank you @lpsinger!

Comment thread MANIFEST.in
include setup.cfg
include docs/figure.png
global-exclude *.py[cod]
global-exclude __pycache__

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just remove this file entirely because when we use setuptools_scm the package just includes everything that is not ignored by git. see: https://setuptools-scm.readthedocs.io/en/v8.2.0/usage/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@aelanman

Copy link
Copy Markdown
Owner

Thanks for doing this, @lpsinger . I'm happy to merge this, but you may want to take a look at the bland branch (PR #46 ). This drops the spiceypy dependency, instead using jplephem for kernel handling.

@aelanman aelanman merged commit 61383ea into aelanman:main May 11, 2026
14 checks passed
@lpsinger lpsinger deleted the pyproject-toml branch May 11, 2026 18:35
@lpsinger

Copy link
Copy Markdown
Contributor Author

What's the connection between pyrpoject.toml and #46?

I was thinking you might want to review and merge #46 before you/we/I move to src layout, just because #46 touches many files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to pyproject.toml package specification

3 participants